Michael Niedermayer <[email protected]> added the comment: On Mon, Nov 02, 2009 at 09:09:29AM +0000, Reimar Döffinger wrote: [...] > > > 2) add a void ff_costab_init(int nbits) that initializes the given > > > ff_cos_tabs[nbits-4] > > > > I like this idea. > > I didn't do it because Michael objected to that approach for the sine > windows.
my objection is to a large part due to it being not clear which table is initalized, a ff_cos_tabs shoud be inited by ff_init_ff_cos_tabs(index inta array or something else very clear) also, nbits-4, why is this not nbits ? [...] _____________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1507> _____________________________________________________
