Michael Niedermayer <[email protected]> added the comment: On Mon, Nov 02, 2009 at 04:22:44PM +0000, Reimar Döffinger wrote: > On Mon, Nov 02, 2009 at 01:07:23PM +0000, Michael Niedermayer wrote: > > On Mon, Nov 02, 2009 at 09:09:29AM +0000, Reimar Döffinger wrote: > > [...] > > > > > 2) add a void ff_costab_init(int nbits) that initializes the given > > > > > ff_cos_tabs[nbits-4] > > > > > > > > I like this idea. > > > > > > I didn't do it because Michael objected to that approach for the sine > > > windows. > > > > my objection is to a large part due to it being not clear which table is > > initalized, a > > ff_cos_tabs > > shoud be inited by > > ff_init_ff_cos_tabs(index inta array or something else very clear) > > also, nbits-4, why is this not nbits ? > > So, do I understand you right that you're probably fine with a > ff_init_ff_cos_tabs(int index) > function, after changing > ff_cos_tabs so that we will use [nbits] instead of [nbits-4] ( > by just adding 4 NULL entries at the start of the table, "costing" > up to 32 extra bytes)?
yes [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There will always be a question for which you do not know the correct awnser. _____________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1507> _____________________________________________________
