Reimar Döffinger <[email protected]> added the comment: On Sun, Nov 29, 2009 at 01:54:23PM +0000, Carl Eugen Hoyos wrote: > With patch: > ==5041== 2 bytes in 1 blocks are definitely lost in loss record 1 of 3 > ==5041== at 0x4C23570: memalign (vg_replace_malloc.c:460) > ==5041== by 0x4C2362A: posix_memalign (vg_replace_malloc.c:569) > ==5041== by 0xABD0C4: av_malloc (mem.c:66) > ==5041== by 0x4E933B: aac_encode_init (aacenc.c:186) > ==5041== by 0x4DC87A: avcodec_open (utils.c:487) > ==5041== by 0x40BDFC: av_encode (ffmpeg.c:2027) > ==5041== by 0x40A2EF: main (ffmpeg.c:3992)
The avctx->extradata still needs to be freed. Also this IMO involves an API issue, ff_psy_preprocess_init and ff_psy_preprocess_end just do not match together, either init should take a pointer instead of return one (so that the context can be emebedded into another struct without a separate allocation), or _end should take a pointer to a pointer as an argument so that av_freep can be used. _____________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1577> _____________________________________________________
