Aleksey Nogin <[email protected]> added the comment: > The bug this issue is about was a bug in LAME that was fixed > (probably in 3.98.3).
You are mistaken. LAME did not have a bug - ffmpeg did (and still does), and LAME added a workaround. See http://sourceforge.net/tracker/?func=detail&aid=2553863&group_id=290&atid=100290 - it fully identifies the issue: -- Date: 2009-03-24 13:49 -- Sender: robert [Project Admin] -- -- If I find some time, I'll add a workaround for the FFMPEG bug. Maybe -- it will be in 3.98.3, to be released sometime this year. -- -- Note: FFMPEG seems to be calling lame_encode_flush in a loop, -- instead of once only. My patch fixes the "calling lame_encode_flush in a loop, instead of once only" issue correctly identified by LAME people as an ffmpeg bug. More from the LAME entry: -- Date: 2009-02-03 13:17 -- Sender: robert [Project Admin] [...] -- it isn't really a bug inside LAME library, it's just not well -- documented in lame.h. [...] -- Date: 2009-02-02 13:13 -- Sender: robert [Project Admin] -- -- A negative return value signals a fatal error, in this case it -- signals "buffer too small". As I understand (have not actually looked at older versions of ffmpeg and LAME) - ffmpeg was (always?) using lame_encode_flush incorrectly, but it never resulted in anything user-visible until a change in 3.98.2 cause this incorrect usage to produce an error. In 3.98.3 LAME change again so that ffmpeg's incorrect usage is once again tolerated. I propose to fix the incorrect usage on the ffmpeg side. > If you think you found a bug in FFmpeg (which should not be "FFmpeg > does not contain a workaround for fixed LAME bugs"), please open a > new issue with a reproducible test case. No thanks - if you are not willing to spend a minute of your time to listen what I am telling you, then I am not going to waste my time on it. The patch works for me, I am happy. I did my "open source civic duty" by reporting my findings to you, but it would seem you are more interested in pointing the fingers at LAME that in actually fixing the problem. Have a good day. ---------- status: closed -> open substatus: invalid -> analyzed ________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/issue803> ________________________________________________
