Vitor <vitor1...@gmail.com> added the comment:

On 07/21/2010 07:35 PM, Michael Niedermayer wrote:
> 
> Michael Niedermayer<michae...@gmx.at>  added the comment:
> 
> On Wed, Jul 21, 2010 at 01:04:16PM +0000, Vitor wrote:
>>
>> New patch that also fix RGB48{BE,LE}.
>>
>> RGB8, RGB4 and MONO{WHITE,BLACK} are still broken but I think it is better to
>> just error out saying that full_chroma_int is not supported for these outputs
>> (and it is not very meaningful anyway).

[...]

>> +    case PIX_FMT_RGB555:
>> +            YSCALE_YUV_2_RGBX_FULL_C(1<<21, 0)
>> +            ((uint16_t *)dest)[0] = B>>25 | ((G>>20)&  (63<<  5)) |
>> +                ((R>>15)&  (63<<  10));
>> +                dest+= 2;
>> +            }
>> +        break;
> 
> missing dithering

True, but it probably will require more radical changes than the attached patch.
BTW, is there a reason why yuvj444p -> rgb555 does dithering while yuvj420p ->
rbg555 doesn't?

________________________________________________
FFmpeg issue tracker <iss...@roundup.ffmpeg.org>
<https://roundup.ffmpeg.org/issue2113>
________________________________________________

Reply via email to