Baptiste Coudurier <[email protected]> added the comment:
On 10/23/10 8:46 PM, Baptiste Coudurier wrote:
>
> Baptiste Coudurier <[email protected]> added the comment:
>
> On 10/4/10 5:00 PM, Lou wrote:
>>
>> New submission from Lou <[email protected]>:
>>
>> Using this sample as input:
>> http://samples.mplayerhq.hu/DV-raw/
>>
>> yadif adds artifacts on the top row of pixels on Arch Linux 64-bit. These
>> artifacts appear with both ffplay and ffmpeg. The artifacts do not appear on
>> videos encoded with 32-bit Arch Linux and 32-bit Ubuntu Lucid.
>
> Confirmed, if you memset 0 the pictures after get_buffer, this bug
> doesn't appear,
> however I'm not sure this is the correct fix.
> Michael what do you think ?
I have this patch but I don't think this is the correct solution.
________________________________________________
FFmpeg issue tracker <[email protected]>
<https://roundup.ffmpeg.org/issue2272>
________________________________________________
Index: libavfilter/vf_yadif.c
===================================================================
--- libavfilter/vf_yadif.c (revision 25819)
+++ libavfilter/vf_yadif.c (working copy)
@@ -157,8 +157,10 @@
picref->video->w = w;
picref->video->h = h;
- for (i = 0; i < 3; i++)
+ for (i = 0; i < 3; i++) {
+ memset(picref->data[i], 0, (height>>!!i)*picref->linesize[i]);
picref->data[i] += 3 * picref->linesize[i];
+ }
return picref;
}
