Paulos K <[email protected]> added the comment: I had a problem with interlaced/mp4 and Your patch helped, but there is one thing that worries me a little bit. The line: x264_encoder_reconfig (x4->enc, &x4->params); overwrites x4->enc->param params based on x4->params. So just before invoking it, Your patch modifies following field: x4->params.b_tff
The problem is that x4->params.b_tff field is not the only one that differs between x4->enc->param params and x4->params. Literally I noticed for my movie that these fields also are different: X264Context *x4; src: x4->params dst: x4->enc->param < b_deblocking_filter = 1, > b_deblocking_filter = 2048, < b_transform_8x8 = 1, > b_transform_8x8 = 128, < b_chroma_me = 1, > b_chroma_me = 256, < b_mixed_references = 1, > b_mixed_references = 64, < b_fast_pskip = 1, > b_fast_pskip = 256, This causes implicit change of those fields while invoking x264_encoder_reconfig (x4->enc, &x4->params); is it the intention or does the patch do too much? best regards, Paul ________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/issue2012> ________________________________________________
