Hello, I would like to request a review of the current LC AAC code.
My aim is to find and fix any outstanding known bugs and clean up the code to an acceptable (or better :)) state for FFmpeg trunk inclusion. There is apparently some code not relating to LC AAC that is unused. I need to look at this myself but I am told it pertains to the LTP mode that has never been widely used. I propose that this unused code be left under some '#if 0' (or whatever is appropriate) with a note explaining why the code is there and what is missing such that someone can finish it at some point. It is not a personal priority for me to complete the LTP code but I may revisit it at a later date, if nothing more important arises, after ensuring the vastly more commonly used modes are functional, i.e. LC, HE v1 and HE v2. And I'll still be trying to iron out AMR-NB issues as I find the time. :) When I've got that code functioning properly and outputting recognisable sound, I'll request a review for that too. I'm always open to comments on how to improve my approach to developing these codecs whether it's relating to the code itself or how I'm managing svn commits or anything at all. Best regards, Rob _______________________________________________ FFmpeg-soc mailing list [email protected] http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
