On Fri, May 30, 2008 at 06:30:21PM +0200, Vitor Sessak wrote: [...] > > (5) I have not resolved the issue of removing memcpy. There is only one > > call to memcpy in the code; to get rid of it is likely to require some > > significant change to the avfilter API, that will have to involve Vitor. > > In these circumstances, I wonder whether it would make sense to commit > > the code to SOC anyway, and then remove the one call to memcpy when > > we'll know how. (Observe that this situation is common to several filters.) > > I've discussed it a little with vmrsss in pvt and I think the solution > to it would be to negotiate the link dimensions during graph creation as > we do for pix_fmt. But after this is done, the changes to make vf_pad.c > memcpy-less would be rather minor, so I think this filter is better > commited to the soc tree (after review) instead of bitrotting as a patch > in the mailing list.
as i said i dont mind it being commited to soc i do mind it being commited to ffmpeg-svn before the issue is solved. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch
signature.asc
Description: Digital signature
_______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
