On Sun, Jun 08, 2008 at 11:33:15PM +0200, bwolowiec wrote:
>
> Log:
> initial commit: simple nellymoser encoder. It's slow and has average quality
> of sound.
>
> --- (empty file)
> +++ nellyenc/checkout.sh Sun Jun 8 23:33:15 2008
> @@ -0,0 +1,16 @@
> +FILES="nellymoserenc.c"
This is missing '#!/bin/sh'.
> --- (empty file)
> +++ nellyenc/nellymoserenc.c Sun Jun 8 23:33:15 2008
> @@ -0,0 +1,326 @@
> + if(avctx->channels!=1){
nit: sometimes you use 'if(', sometimes 'if ('.
> + av_log(s->avctx, AV_LOG_DEBUG, "%3i: %f (%f)\n", i, s->mdct_out[i],
> + s->float_buf[i]);
> + av_log(s->avctx, AV_LOG_DEBUG, " exp: %f\n",
> + -pow(2,val/2048.)*scale);
> + av_log(s->avctx, AV_LOG_DEBUG, "bk=%3i best_deq=%f
> send=%f\n",
> + bk,
> + best,
> +
> (ff_nelly_dequantization_table[(1<<bits[j])-1+bk]*pval)
> + );
> + av_log(s->avctx, AV_LOG_DEBUG, "count=%i (%i)\n",
> + put_bits2_count(&pb),
> + NELLY_HEADER_BITS + NELLY_DETAIL_BITS
> + );
> + av_log(s->avctx, AV_LOG_DEBUG, "count=%i (%i)\n",
> + put_bits2_count(&pb),
> + NELLY_HEADER_BITS + NELLY_DETAIL_BITS
> + );
weird and/or inconsistent indentation
> +AVCodec nellymoser_encoder = {
> + "nellymoser",
> + CODEC_TYPE_AUDIO,
> + CODEC_ID_NELLYMOSER,
> + sizeof(NellyMoserEncodeContext),
> + encode_init,
> + encode_tag,
> + encode_end,
> + NULL,
> +};
This is missing a codec long name.
Diego
_______________________________________________
FFmpeg-soc mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
