2008/7/15 Michael Niedermayer <[EMAIL PROTECTED]>: > On Tue, Jul 15, 2008 at 04:29:52PM +0100, Robert Swain wrote: >> 2008/7/15 Michael Niedermayer <[EMAIL PROTECTED]>: >> > On Tue, Jul 15, 2008 at 04:03:03PM +0100, Robert Swain wrote: >> >> 2008/7/15 Benjamin Larsson <[EMAIL PROTECTED]>: >> >> > superdump wrote: >> >> >> Author: superdump >> >> >> Date: Tue Jul 15 15:47:11 2008 >> >> >> New Revision: 2791 >> >> >> >> >> >> Log: >> >> >> Add some allocation checks >> >> >> >> >> > >> >> > There should be a NOMEM error. Look in cook.c for reference. >> >> >> >> Or rather atrac3.c or so. How about the attached? I had to add code to >> >> propagate the error values through to the main functions as I assume >> >> only the return values of the init, decode, encode and close functions >> >> really matter. >> > [...] >> > >> >> - if(program_config_element_default(ac, channels) < 0) >> >> + if((ret = program_config_element_default(ac, channels))) >> >> return -1; >> > >> > shouldnt that be return ret? >> >> It should be ret, yes. Fixed. >> >> > Also the <0 disappeared, was that intended? >> >> It was intended, yes. All other values returned were either 0 or -1 >> and I didn't know what the value of AVERROR(ENOMEM) was so I removed >> the < 0. > > AVERROR() is <0
OK, noted. But it still doesn't change the behaviour. :) Rob _______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
