On Sun, Jan 25, 2009 at 06:04:13AM +0100, Diego Biurrun wrote:
> On Sun, Jan 25, 2009 at 12:04:52AM +0100, Michael Niedermayer wrote:
> > On Sat, Jan 24, 2009 at 07:05:47PM +0100, Diego Biurrun wrote:
> > > On Sat, Jan 24, 2009 at 06:47:16PM +0100, Sascha Sommer wrote:
> > > >
> > > > On Samstag, 17. Januar 2009, Diego Biurrun wrote:
> > > > > On Sat, Jan 17, 2009 at 12:56:08PM -0800, Baptiste Coudurier wrote:
> > > > > > faust3 wrote:
> > > > > > > [...]
> > > > > > >
> > > > > > > if ( idx == 126 )
> > > > > > > {
> > > > > > > while(i < 4){
> > > > > >
> > > > > > You may need to uniformize '{' placement, also get rid of these
> > > > > > spaces
> > > > > > before and after parentheses.
> > > > >
> > > > > I would suggest K&R style, which has spaces after if/while:
> > > > >
> > > > > if (idx == 126) {
> > > > > while (i < 4) {
> > > >
> > > > I prefere them without spaces.
> > > > Anyway I'll try to fix this before I submit the first patch.
> > >
> > > I suggest leaving personal preference aside in favor of a generally
> > > consistent coding style across the project.
> >
> > And id like to say that this is misordering priorities
> > A common style is a good thing, raising very small fineprint like these
> > spaces up to a strict rule is not.
>
> I never said anything like what you imply.You suggested to follow the fineprint against ones personal preference Thats suggesting that its more important You didnt suggest a rule to the same effect, true, my words where poorly choosen. Still my point stands that i belive that your suggestion is having the priorities in a less than ideal order. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation of the exact
signature.asc
Description: Digital signature
_______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
