On Sun, May 24, 2009 at 09:55:33PM +0200, Diego Biurrun wrote:
> On Sun, May 24, 2009 at 09:38:10PM +0200, Thilo Borgmann wrote:
> > > duE
> > > ...
> > > But this is a bad commit message.  It conveys no useful information.
> > > ... 
> > > You mix multiple different into one commit.  Bad.
> > > ...
> > > Indentation should be fixed.
> > > ...
> > > Dropping the als function prefix requires changes to the AVCodec
> > > declaration.
> > 
> > So few changes and so much wrong.... seems like I have to get back into
> > the standards.
> 
> You're learning the ropes, don't worry.  I just hope the other SoC
> student's were listening and don't repeat your mistakes.
> 
> > I hope I've done better now.
> 
> You have.  Now please fix the commit message so that it provides useful
> information and describes the changes you actually did.

Can we now please have the commit message fixed?

Diego
_______________________________________________
FFmpeg-soc mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc

Reply via email to