2009/6/4 Diego Biurrun <[email protected]>: > On Thu, Jun 04, 2009 at 01:14:13PM +0200, cmcq wrote: >> Author: cmcq >> Revision: 4385 >> Property Name: svn:log >> Action: modified >> >> Property diff: >> --- old property value >> +++ new property value >> @@ -1 +1 @@ >> -Set p->pitch_vector >> \ No newline at end of file >> +p->pitch_vector was not being set >> \ No newline at end of file > > This provides close to no information unless you are deeply familiar > with the code. What did you do exactly? Why? > > Diego
I did some debugging and noticed that p->pitch_vector was being used but not set. The pitch vector is calculated in "decode_pitch_vector" but it was not copied to p->pitch_vector. This looked like an accidental omission in otherwise correct code. The commit message makes it clear that it's just a fix to a simple mistake. I can't see how to make this interesting to someone not familiar with the code. _______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
