On 06/12/2009 06:21 PM, Baptiste Coudurier wrote: > Hi, > > On 6/12/2009 5:53 PM, gkovacs wrote: >> Author: gkovacs >> Date: Sat Jun 13 02:53:22 2009 >> New Revision: 4440 >> >> Log: >> removed unnecessary code, should work with same-codec different-format >> combinations as-is, requires an (in-progress) patch to ffmpeg.c and ffplay.c >> to handle changing streams during decoding >> > > Please avoid suck huge commits which are just impossible to review. > Split changes, keeping them related, and do small but frequent commits. > > Quick review: > >> [...] >> >> +char* buf_getline(ByteIOContext *s) > > This should be static. >
I will be using that function, as well as all the others declared in playlist.h, in the PLS playlist demuxer as well, which is in a separate file. Isn't declaring it as static going to restrict it to a single playlist demuxer? >> [...] >> >> Modified: concat/libavformat/playlist.h >> ============================================================================== >> --- concat/libavformat/playlist.h Fri Jun 12 21:24:59 2009 (r4439) >> +++ concat/libavformat/playlist.h Sat Jun 13 02:53:22 2009 (r4440) >> >> [...] >> >> @@ -46,5 +51,14 @@ PlaylistD* av_make_playlistd(unsigned ch >> >> int check_file_extn(char *cch, char *extn); >> >> +int compare_bufs(unsigned char *buf, unsigned char *rbuf); >> + >> int playlist_populate_context(PlaylistD *playld, AVFormatContext *s); >> >> +char* conc_strings(char *string1, char *string2); >> + >> +char* buf_getline(ByteIOContext *s); >> + >> +void split_wd_fn(char *filepath, char **workingdir, char **filename); >> + >> +unsigned int get_stream_offset(AVFormatContext *s); > > And should therefore and ideally not need to be declared in a header. > _______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
