#3420: Overlaying / hardcoding subtitles - last subtitle not done correctly
-------------------------------------+-------------------------------------
             Reporter:  adamc        |                    Owner:
                 Type:  defect       |                   Status:  new
             Priority:  normal       |                Component:
              Version:  git-master   |  undetermined
             Keywords:  vobsub       |               Resolution:
             Blocking:               |               Blocked By:
Analyzed by developer:  0            |  Reproduced by developer:  0
-------------------------------------+-------------------------------------

Comment (by adamc):

 For reference, after a quick search, I notice that the code I mentioned in
 my previous comment for Subtitle Edit, for parsing the subtitles:
 
​https://github.com/SubtitleEdit/subtitleedit/blob/master/src/Logic/VobSub/SubPicture.cs#L109

 is somewhat similar to the ffmpeg code here:

 https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/dvdsubdec.c#L263

 The delay / sub_header->end_display_time calculations are slightly
 different.

 I have no idea if the parsing and calculation routine is the cause of the
 problem (since all but the last subtitle display for the correct
 duration), or whether the rendering code somewhere might forget to do
 something on the last index of a loop somewhere...

 thanks.

--
Ticket URL: <https://trac.ffmpeg.org/ticket/3420#comment:3>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
_______________________________________________
FFmpeg-trac mailing list
[email protected]
http://avcodec.org/mailman/listinfo/ffmpeg-trac

Reply via email to