#6742: ffmpeg-3.4/libavformat/nutdec.c:585: suspicious if ?
-------------------------------------+-------------------------------------
Reporter: dcb | Type: defect
Status: new | Priority: normal
Component: | Version:
undetermined | unspecified
Keywords: | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
-------------------------------------+-------------------------------------
[ffmpeg-3.4/libavformat/nutdec.c:585]: (style) Same expression on both
sides of '||'.
Source code is
if (st->r_frame_rate.num >= 1000LL*st->r_frame_rate.den ||
st->r_frame_rate.num < 0 || st->r_frame_rate.num < 0)
maybe better code
if (st->r_frame_rate.num >= 1000LL*st->r_frame_rate.den ||
st->r_frame_rate.num < 0 || st->r_frame_rate.den < 0)
--
Ticket URL: <https://trac.ffmpeg.org/ticket/6742>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
_______________________________________________
FFmpeg-trac mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-trac
