#10883: first 5 bytes of all MPEGTS KLV data is dropped
---------------------------------+------------------------------------
Reporter: tmc2001 | Owner: (none)
Type: defect | Status: new
Priority: normal | Component: avformat
Version: 6.1 | Resolution:
Keywords: | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
---------------------------------+------------------------------------
Changes (by tmc2001):
* summary: first 5 bytes of all KLV data is dropped => first 5 bytes of
all MPEGTS KLV data is dropped
Old description:
> This is a regression from 6.0 to 6.1, introduced by changeset:
> https://github.com/FFmpeg/FFmpeg/commit/468615f2045da325e0f73e8e668d49cf456ccb37
>
> This change causes the first 5 bytes of all KLV data to be dropped, which
> is incorrect.
>
> I am not sure on the history of why the 5 byte skip is needed, but, if
> that skip is needed, might I at least recommend to change it to:
>
> if (pes->stream_type == 0x15 && pes->st->codecpar->codec_id ==
> AV_CODEC_ID_SMPTE_KLV && buf_size >= 5)
>
> Thank you.
New description:
This is a regression from 6.0 to 6.1, introduced by changeset:
https://github.com/FFmpeg/FFmpeg/commit/468615f2045da325e0f73e8e668d49cf456ccb37
This change causes the first 5 bytes of all MPEGTS KLV data to be dropped,
which is incorrect.
I am not sure on the history of why the 5 byte skip is needed, but, if
that skip is needed, might I at least recommend to change it to:
if (pes->stream_type == 0x15 && pes->st->codecpar->codec_id ==
AV_CODEC_ID_SMPTE_KLV && buf_size >= 5)
Thank you.
--
--
Ticket URL: <https://trac.ffmpeg.org/ticket/10883#comment:1>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker_______________________________________________
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-trac
To unsubscribe, visit link above, or email
ffmpeg-trac-requ...@ffmpeg.org with subject "unsubscribe".
