#11353: [Regression] "libswscale/utils.c" potentially introduced logical error
------------------------------------+-----------------------------------
Reporter: sylware | Owner: (none)
Type: defect | Status: new
Priority: critical | Component: swscale
Version: git-master | Resolution:
Keywords: | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 1 |
------------------------------------+-----------------------------------
Changes (by MasterQuestionable):
* analyzed: 0 => 1
* cc: MasterQuestionable (added)
* summary: [PATCH] Bug introduced upon API change => [Regression]
"libswscale/utils.c" potentially introduced logical error
Comment:
͏ Relevant:
͏
https://github.com/FFmpeg/FFmpeg/commit/ed5dd675624c83d9c69b406ce30e4e09f29970e3
#diff-
29d45229c3c98e9f43a9ce70f75b626cb66a8297d680d6fe6f7bba1a54b9c9b4R2552
͏ Proposing patch:
{{{#!diff
--- a/libswscale/utils.c
+++ b/libswscale/utils.c
@@ -2548,14 +2548,14 @@ SwsContext *sws_getCachedContext(SwsContext *prev,
int srcW,
if (!param)
param = default_param;
- if (prev && (prev->src_w == srcW ||
- prev->src_h == srcH ||
- prev->src_format == srcFormat ||
- prev->dst_w == dstW ||
- prev->dst_h == dstH ||
- prev->dst_format == dstFormat ||
- prev->flags == flags ||
- prev->scaler_params[0] == param[0] ||
+ if (prev && (prev->src_w == srcW &&
+ prev->src_h == srcH &&
+ prev->src_format == srcFormat &&
+ prev->dst_w == dstW &&
+ prev->dst_h == dstH &&
+ prev->dst_format == dstFormat &&
+ prev->flags == flags &&
+ prev->scaler_params[0] == param[0] &&
prev->scaler_params[1] == param[1])) {
return prev;
}
}}}
--
Ticket URL: <https://trac.ffmpeg.org/ticket/11353#comment:1>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
_______________________________________________
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-trac
To unsubscribe, visit link above, or email
ffmpeg-trac-requ...@ffmpeg.org with subject "unsubscribe".
