#11456: ffvp9 race
-------------------------------------+-------------------------------------
Reporter: Ronald S. | Owner: (none)
Bultje |
Type: defect | Status: open
Priority: important | Component: avcodec
Version: git-master | Resolution:
Keywords: | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
-------------------------------------+-------------------------------------
Comment (by Ronald S. Bultje):
This might be a mundane tsan issue. I can get the report to disappear with
this patch:
{{{
$ git diff
diff --git a/libavcodec/threadprogress.c b/libavcodec/threadprogress.c
index 62c4fd898b..aa72ff80e7 100644
--- a/libavcodec/threadprogress.c
+++ b/libavcodec/threadprogress.c
@@ -55,9 +55,8 @@ void ff_thread_progress_report(ThreadProgress *pro, int
n)
if (atomic_load_explicit(&pro->progress, memory_order_relaxed) >= n)
return;
- atomic_store_explicit(&pro->progress, n, memory_order_release);
-
ff_mutex_lock(&pro->progress_mutex);
+ atomic_store_explicit(&pro->progress, n, memory_order_release);
ff_cond_broadcast(&pro->progress_cond);
ff_mutex_unlock(&pro->progress_mutex);
}
}}}
--
Ticket URL: <https://trac.ffmpeg.org/ticket/11456#comment:2>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
_______________________________________________
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-trac
To unsubscribe, visit link above, or email
ffmpeg-trac-requ...@ffmpeg.org with subject "unsubscribe".
