#10732: avcodec_flush_buffers() not resetting E-AC-3 decoder
-------------------------------------+-------------------------------------
Reporter: Peter | Owner: (none)
Krefting |
Type: defect | Status: closed
Priority: normal | Component: avcodec
Version: git-master | Resolution: fixed
Keywords: eac3 | Blocked By:
Blocking: | Reproduced by developer: 1
Analyzed by developer: 1 |
-------------------------------------+-------------------------------------
Changes (by James):
* priority: minor => normal
* resolution: => fixed
* status: open => closed
Comment:
Replying to [comment:11 Peter Krefting]:
> Thank you, the updated patch from patchwork does indeed fix the issue I
am seeing.
Fixed in 045a8b15b19ec7f872fb01cfb986faeaa26cb8bb.
> Is it possible to identify which codecs do not have an implementation
for avcodec_flush_buffers(), we would like to re-use the objects as much
as possible, for performance reasons. Clearing an object is usually
cheaper than deallocation and allocating a new one.
All decoders by default support being flushed with that function. Those
that need it provide an internal flush() callback to clear some decoder
private state. In the case of ac3/eac3 as you found out, it was most
likely forgotten.
If you find another decoder where flushing doesn't behave as it should,
create another ticket.
--
Ticket URL: <https://trac.ffmpeg.org/ticket/10732#comment:12>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
_______________________________________________
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-trac
To unsubscribe, visit link above, or email
ffmpeg-trac-requ...@ffmpeg.org with subject "unsubscribe".
