#11516: avformat/mov: Parse 'name' atom for title metadata
-------------------------------------+------------------------------------
Reporter: Yuxin Wang | Owner: (none)
Type: enhancement | Status: closed
Priority: minor | Component: avformat
Version: git-master | Resolution: fixed
Keywords: | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
-------------------------------------+------------------------------------
Changes (by Yuxin Wang):
* resolution: => fixed
* status: new => closed
Old description:
> `mov_write_track_udta_tag` in libavformat/movenc.c uses the 'name' atom
> for recording track titles, but the 'name' atom is not recognized in
> libavformat/mov.c.
>
> {{{
> ---
> libavformat/mov.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 57d9364..6e8c40c 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -392,6 +392,7 @@ static int mov_read_udta_string(MOVContext *c,
> AVIOContext *pb, MOVAtom atom)
> return mov_metadata_loci(c, pb, atom.size);
> case MKTAG( 'm','a','n','u'): key = "make"; break;
> case MKTAG( 'm','o','d','l'): key = "model"; break;
> + case MKTAG( 'n','a','m','e'): key = "title"; break;
> case MKTAG( 'p','c','s','t'): key = "podcast";
> parse = mov_metadata_int8_no_padding; break;
> case MKTAG( 'p','g','a','p'): key = "gapless_playback";
> --
> 2.39.5 (Apple Git-154)
> }}}
>
> I submitted this patch to ffmpeg-devel, but it might have been filtered
> into spam since I receive no response when trying to subscribe to ffmpeg-
> devel.
>
> In addition, I found
> [https://patchwork.ffmpeg.org/project/ffmpeg/patch/20180521191403.18204-1-...@nikjohnson.net/
> a similar patch] from 2018 that was also not merged. Is there a specific
> reason for this?
New description:
`mov_write_track_udta_tag` in libavformat/movenc.c uses the 'name' atom
for recording track titles, but the 'name' atom is not recognized in
libavformat/mov.c.
{{{
---
libavformat/mov.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 57d9364..6e8c40c 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -392,6 +392,7 @@ static int mov_read_udta_string(MOVContext *c,
AVIOContext *pb, MOVAtom atom)
return mov_metadata_loci(c, pb, atom.size);
case MKTAG( 'm','a','n','u'): key = "make"; break;
case MKTAG( 'm','o','d','l'): key = "model"; break;
+ case MKTAG( 'n','a','m','e'): key = "title"; break;
case MKTAG( 'p','c','s','t'): key = "podcast";
parse = mov_metadata_int8_no_padding; break;
case MKTAG( 'p','g','a','p'): key = "gapless_playback";
--
2.39.5 (Apple Git-154)
}}}
~~I submitted this patch to ffmpeg-devel, but it might have been filtered
into spam since I receive no response when trying to subscribe to ffmpeg-
devel.~~
In addition, I found
[https://patchwork.ffmpeg.org/project/ffmpeg/patch/20180521191403.18204-1-...@nikjohnson.net/
a similar patch] from 2018 that was also not merged. Is there a specific
reason for this?
Update: I didn't notice that the subscription confirmation email was also
filtered into my spam. I'll resubmit the patch. Closing ticket for now.
--
--
Ticket URL: <https://trac.ffmpeg.org/ticket/11516#comment:1>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
_______________________________________________
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-trac
To unsubscribe, visit link above, or email
ffmpeg-trac-requ...@ffmpeg.org with subject "unsubscribe".
