On Tue, Jun 14, 2011 at 11:52 PM, Eric Blake <ebl...@redhat.com> wrote: > On 06/14/2011 04:46 PM, James Youngman wrote: >> * find/ftsfind.c (show_outstanding_execdirs): Now that >> execp->state.cmd_argc is a size_t, we can't print it with %d. So >> print it with PRIuMAX (and include <inttypes.h> to define that). > > Or suck in the fprintf-posix module, and use %zu instead of PRIuMAX, to > save a cast. But that's pretty heavy-weight, so your approach is fine.
I thought the cost of the uintmax_t conversion was bearable considering that this is debug code anyway. (I found http://lists.gnu.org/archive/html/bug-gnulib/2010-08/msg00108.html useful, thanks). > >> @@ -31,6 +42,7 @@ >> (prec_name): Likewise! Also remove spurious parentheses around >> return value. >> (prec_name): Remove spurious parentheses around return value. >> + >> * lib/buildcmd.h (buildcmd_state): change types of several fields > > Was this hunk intentional? No. Drat. This is something I often do; Emacs's add-change-log-entry-other-window command often opens up a blank line in the previous ChangeLog entry when actually I want to add a new ChangeLog entry, but when I go to add the new entry in the right place, sometimes I forget to delete the unwanted line break. This time I didn't spot that when reading the patches. Thanks for the corrections, I've submitted them (plus the ones you suggested for the other patch). James. _______________________________________________ Findutils-patches mailing list Findutils-patches@gnu.org https://lists.gnu.org/mailman/listinfo/findutils-patches
