Update of /cvsroot/fink/web/pdb
In directory sc8-pr-cvs17.sourceforge.net:/tmp/cvs-serv20238

Modified Files:
        browse.php handle_options.inc index.php package.php 
Log Message:
fix a number of validation issues

Index: handle_options.inc
===================================================================
RCS file: /cvsroot/fink/web/pdb/handle_options.inc,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -d -r1.4 -r1.5
--- handle_options.inc  5 Dec 2007 21:42:41 -0000       1.4
+++ handle_options.inc  6 Dec 2007 20:19:20 -0000       1.5
@@ -33,7 +33,7 @@
        addGETParam($getparams, 'doc_id');
        addGETParam($getparams, 'pkg_id');
        foreach ($getparams as $key => $value) {
-               $query_params .= "$key=$value&";
+               $query_params .= "$key=$value&";
        }
        $query_params = rtrim($query_params, '&?');
        return $query_params;
@@ -189,5 +189,5 @@
        $query->setUnique(true);
 }
 
-$link_alternate =  "<link rel=\"alternate\" type=\"application/rss+xml\" 
title=\"RSS\" href=\"rss.php?format=RSS2.0&" . get_query_params() . "\" />\n";
-$link_alternate .= "<link rel=\"alternate\" type=\"application/atom+xml\" 
title=\"Atom\" href=\"rss.php?format=ATOM&" . get_query_params() . "\" />\n";
+$link_alternate =  "<link rel=\"alternate\" type=\"application/rss+xml\" 
title=\"RSS\" href=\"rss.php?format=RSS2.0&amp;" . get_query_params() . "\">\n";
+$link_alternate .= "<link rel=\"alternate\" type=\"application/atom+xml\" 
title=\"Atom\" href=\"rss.php?format=ATOM&amp;" . get_query_params() . "\">\n";

Index: package.php
===================================================================
RCS file: /cvsroot/fink/web/pdb/package.php,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -d -r1.59 -r1.60
--- package.php 6 Dec 2007 20:01:24 -0000       1.59
+++ package.php 6 Dec 2007 20:19:20 -0000       1.60
@@ -129,8 +129,8 @@
                } else {
                        $open_tag = '<a href="' . $p['name'] . '?rel_id=' . 
$p['rel_id'];
                        if ($showall)
-                               $open_tag .= "&showall=on";
-                       $open_tag .= '" alt="' . get_descriptive_name($p) . 
'">';
+                               $open_tag .= "&amp;showall=on";
+                       $open_tag .= '" title="' . get_descriptive_name($p) . 
'">';
                        $close_tag = '</a>';
                }
                return array ( $open_tag, $close_tag );
@@ -147,8 +147,8 @@
        function link_to_package($pobj, $showall = false, $description = '') {
                $pkg_str = '<a href="'. $pobj['name'] . '?doc_id' . 
$pobj['doc_id'];
                if ($showall)
-                       $pkg_str .= '&showall=on';
-               $pkg_str .= '" alt="' . get_descriptive_name($pobj) . 
'">'.$package.'</a> ';
+                       $pkg_str .= '&amp;showall=on';
+               $pkg_str .= '" title="' . get_descriptive_name($pobj) . 
'">'.$package.'</a> ';
                if ($description)
                        $pkg_str .= htmlentities($description);
                return $pkg_str;
@@ -164,8 +164,8 @@
        print "</tr>\n";
 
        print '<tr bgcolor="#ffecbf">';
-       print '<th width="100" align="center"><a 
href="http://feeds.feedburner.com/FinkProjectNews-stable";><img src="' . 
$pdbroot . 'rdf.png" alt="stable RSS feed" border="0"  width="14" height="14" 
/></a> stable</th>';
-       print '<th width="100" align="center"><a 
href="http://feeds.feedburner.com/FinkProjectNews-unstable";><img src="' . 
$pdbroot . 'rdf.png" alt="unstable RSS feed" border="0"  width="14" height="14" 
/></a> unstable</th>';
+       print '<th width="100" align="center"><a 
href="http://feeds.feedburner.com/FinkProjectNews-stable";><img src="' . 
$pdbroot . 'rdf.png" alt="stable RSS feed" border="0"  width="14" 
height="14"></a> stable</th>';
+       print '<th width="100" align="center"><a 
href="http://feeds.feedburner.com/FinkProjectNews-unstable";><img src="' . 
$pdbroot . 'rdf.png" alt="unstable RSS feed" border="0"  width="14" 
height="14"></a> unstable</th>';
        print "</tr>\n";
 
        $color_count = 0;
@@ -261,7 +261,7 @@
 
        show_desc('Usage&nbsp;Hints:', $pobj['descusage']);
 
-       it_item("Section:", '<a 
href="'.$pdbroot.'browse.php?section='.$pobj['section'].'" alt="' . 
$sections[$pobj['section']] . '">'.$pobj['section'].'</a>');
+       it_item("Section:", '<a 
href="'.$pdbroot.'browse.php?section='.$pobj['section'].'" title="' . 
$sections[$pobj['section']] . '">'.$pobj['section'].'</a>');
 
        // Get the maintainer field, and try to parse out the email address
        if ($pobj['maintainer']) {
@@ -282,7 +282,7 @@
                it_item("Maintainer:", '<a 
href="'.$pdbroot.'browse.php?maintainer='.$maintainer.'">'.$maintainer.'</a>');
        }
        if ($pobj['homepage']) {
-               it_item("Website:", '<a href="'.$pobj['homepage'].'" alt="' . 
$pobj['name'] . ' home page">'.$pobj['homepage'].'</a>');
+               it_item("Website:", '<a href="'.$pobj['homepage'].'" title="' . 
$pobj['name'] . ' home page">'.$pobj['homepage'].'</a>');
        }
        if ($pobj['license']) {
                it_item("License:", '<a 
href="http://fink.sourceforge.net/doc/packaging/policy.php#licenses";>'.$pobj['license'].'</a>');
@@ -307,8 +307,8 @@
                        $infofile_tag = '?pathrev=' . $pobj['tag'];
                else
                        $infofile_tag = '';
-               $infofile_html  = '<a 
href="'.$infofile_cvs_url.$infofile_tag.($infofile_tag ? '&' : 
'?').'view=markup" alt="' . $pobj['name'] . ' info 
file">'.$infofile_path.'</a><br>';
-               $infofile_html .= '<a 
href="'.$infofile_cvs_url.$infofile_tag.'" alt="' . $pobj['name'] . ' CVS 
log">CVS log</a>, Last Changed: '. format_solr_date($pobj['infofilechanged']);
+               $infofile_html  = '<a 
href="'.$infofile_cvs_url.$infofile_tag.($infofile_tag ? '&amp;' : 
'?').'view=markup" title="' . $pobj['name'] . ' info 
file">'.$infofile_path.'</a><br>';
+               $infofile_html .= '<a 
href="'.$infofile_cvs_url.$infofile_tag.'" title="' . $pobj['name'] . ' CVS 
log">CVS log</a>, Last Changed: '. format_solr_date($pobj['infofilechanged']);
                it_item("Info-File:", $infofile_html);
        }
 

Index: browse.php
===================================================================
RCS file: /cvsroot/fink/web/pdb/browse.php,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -d -r1.14 -r1.15
--- browse.php  5 Dec 2007 21:18:31 -0000       1.14
+++ browse.php  6 Dec 2007 20:19:20 -0000       1.15
@@ -202,7 +202,7 @@
                } else {
                        print '<td 
class="packageName">'.get_full_version($package).'</td>';
                }
-               print '<td>'.$package['descshort']."</td></tr>\n";
+               print '<td>'.htmlentities($package['descshort'])."</td></tr>\n";
        }
 ?>
 </table>

Index: index.php
===================================================================
RCS file: /cvsroot/fink/web/pdb/index.php,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -d -r1.29 -r1.30
--- index.php   5 Dec 2007 21:18:31 -0000       1.29
+++ index.php   6 Dec 2007 20:19:20 -0000       1.30
@@ -37,14 +37,14 @@
 "unstable" because they are not well-tested.
 You can help improve the situation by testing those packages and
 reporting both success and failure to the package maintainer.
-The <a href="browse.php?tree=testing&nochildren=on">Packages in Testing</a> 
page lists all
+The <a href="browse.php?tree=testing&amp;nochildren=on">Packages in 
Testing</a> page lists all
 packages that still have to pass testing.
 In order to test the packages, you need to configure Fink to <a 
href="http://fink.sourceforge.net/faq/usage-fink.php#unstable";>use
 unstable</a> and then download the latest descriptions by running <i>fink 
selfupdate-rsync</i> 
 (or <i>fink selfupdate-cvs</i> if you can't use rsync for some reason).
 </p>
 <p>Help is also needed to find new maintainers for the <a
-href="browse.php?maintainer=None&nochildren=on">packages without 
maintainers</a>.</p>
+href="browse.php?maintainer=None&amp;nochildren=on">packages without 
maintainers</a>.</p>
 
 <?
 $pkgcount    = memcache_get_key('pdb-package-count');


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Fink-commits mailing list
Fink-commits@lists.sourceforge.net
http://news.gmane.org/gmane.os.apple.fink.cvs

Reply via email to