Update of /cvsroot/fink/fink/perlmod/Fink
In directory sc8-pr-cvs17.sourceforge.net:/tmp/cvs-serv28261
Modified Files:
ChangeLog Validation.pm
Log Message:
Catch a -framework flag usage in .la that can confuse libtool
Index: Validation.pm
===================================================================
RCS file: /cvsroot/fink/fink/perlmod/Fink/Validation.pm,v
retrieving revision 1.273
retrieving revision 1.274
diff -u -d -r1.273 -r1.274
--- Validation.pm 16 Oct 2007 18:29:31 -0000 1.273
+++ Validation.pm 19 Dec 2007 00:08:52 -0000 1.274
@@ -1401,7 +1401,7 @@
# - If a package *Script uses debconf, it should Depends:debconf
# (TODO: should be in preinst not postinst, should be PreDepends not Depends)
# - if a pkg is a -pmXXX but installs files that are not in a XXX-specific path
-# - Catch common error relating to usage of -framework flag in .pc file
+# - Catch common error relating to usage of -framework flag in .pc and .la
files
# - Look for symptoms of missing InfoDocs field in .info
# - Look for packages that contain no files
#
@@ -1736,15 +1736,16 @@
}
# Check for common programmer mistakes relating to passing
-framework flags in pkg-config files
- if ($filename =~ /\.pc$/) {
- if (!-l $File::Find::name and open my $pc_file, '<',
$File::Find::name) {
- while (<$pc_file>) {
+ if ($filename =~ /\.(pc|la)$/) {
+ my $filetype = ($1 eq 'pc' ? 'pkg-config' : 'libtool');
+ if (!-l $File::Find::name and open my $datafile, '<',
$File::Find::name) {
+ while (<$datafile>) {
chomp;
if (/\s((?:-W.,|)-framework)[^,]/) {
- &stack_msg($msgs, "The $1 flag
may get munged by pkg-config. See the gcc manpage for information about passing
options to flags for specific compiler passes.", $filename, $_);
+ &stack_msg($msgs, "The $1 flag
may get munged by $filetype. See the gcc manpage for information about passing
multi-word options to flags for specific compiler passes.", $filename, $_);
}
}
- close $pc_file;
+ close $datafile;
} elsif (!-l _) {
&stack_msg($msgs, "Couldn't read pkg-config
file \"$filename\": $!");
}
Index: ChangeLog
===================================================================
RCS file: /cvsroot/fink/fink/perlmod/Fink/ChangeLog,v
retrieving revision 1.1520
retrieving revision 1.1521
diff -u -d -r1.1520 -r1.1521
--- ChangeLog 15 Dec 2007 00:11:30 -0000 1.1520
+++ ChangeLog 19 Dec 2007 00:08:52 -0000 1.1521
@@ -1,3 +1,7 @@
+2007-12-18 Daniel Macks <[EMAIL PROTECTED]>
+
+ * Validation.pm: Complain if a .la contains -framework not in -Wl,
+
2007-11-24 Daniel Macks <[EMAIL PROTECTED]>
* NetAccess.pm: Tell user if overriding the DownloadMethod pref.
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Fink-commits mailing list
[email protected]
http://news.gmane.org/gmane.os.apple.fink.cvs
