I think we should make this patch too for the next fink, just gets rid of some annoying warnings with 5.8.

-Ben

Begin forwarded message:

From: [EMAIL PROTECTED] (Randal L. Schwartz)
Date: Thu Nov 28, 2002 7:08:47 AM US/Pacific
To: Paul Gaborit <[EMAIL PROTECTED]>
Cc: David <[EMAIL PROTECTED]>, [EMAIL PROTECTED]
Subject: Re: [Fink-devel] fink check on a non existant package spews error messages

"Paul" == Paul Gaborit <[EMAIL PROTECTED]> writes:
Paul> At 12:35 +0100 28/11/02, David wrote:
look here:

sudo fink check cdrtools
Using a hash as a reference is deprecated at
/sw/lib/perl5/Fink/Validation.pm line 229, <SW_VERS> line 2.
Using a hash as a reference is deprecated at
/sw/lib/perl5/Fink/Validation.pm line 241, <SW_VERS> line 2.
Using a hash as a reference is deprecated at
/sw/lib/perl5/Fink/Validation.pm line 251, <SW_VERS> line 2.
Using a hash as a reference is deprecated at
/sw/lib/perl5/Fink/Validation.pm line 258, <SW_VERS> line 2.
Using a hash as a reference is deprecated at
/sw/lib/perl5/Fink/Validation.pm line 265, <SW_VERS> line 2.
Using a hash as a reference is deprecated at
/sw/lib/perl5/Fink/Validation.pm line 276, <SW_VERS> line 2.
Failed: File "cdrtools" does not exist!
Paul> This new warning appeared with Perl 5.8.x.

Yes, that's definitely ALWAYS been invalid syntax:

%allowed_license_values->{$value}

but because of lots of crufty corners in the parser, it was formerly
passed as if you had said

$allowed_license_values{$value}

which is what you should change this to. Apparently, in many places.

A global search for

/%\w+->{/

in the sources will catch them all. Ahh, here's the list:

Validation.pm:229: if (not %allowed_license_values->{$value}) {
Validation.pm:241: if ($value and not %allowed_type_values->{$value}) {
Validation.pm:251: if (%obsolete_fields->{$field}) {
Validation.pm:258: if (%boolean_fields->{$field} and not (lc $value) =~ /^\s*(true|yes|on|1|false|no|off|0)\s*$/) {
Validation.pm:265: if (%name_version_fields->{$field} and $value) {
Validation.pm:276: unless (%known_fields->{$field}

I suspect these were all written by the same confused author. :)

--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<[EMAIL PROTECTED]> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!


-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T
handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en
_______________________________________________
Fink-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/fink-devel



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Fink-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/fink-devel

Reply via email to