Am Sonntag, 16.11.03 um 13:34 Uhr schrieb Michael G Schwern:
On Sat, Nov 15, 2003 at 03:58:01AM -0800, Max Horn wrote:The test was worthless because it was incorrect :-). It didn't test the actual behavior of the code. Of course that's not your fault since the behavior isn't documented anywhere...disable not working test
Tests are there to tell you something might be broken. If you just comment
it out when it starts failing then the tests are worthless.
You don't disable a failing test. You either fix the bug, fix the test or
post a bug report and set TODO (see t/Command/failure.t for examples).
So far that particular test failed twice for me when in fact everything was working fine. Hence I disabled it. I didn't have the time to fix it properly. Next time I'll add a FIXME comment to it. From my POV failing a bug report for this would have been *way* overkill. It was obvious to me that the test failed since it David fixed get_perl_arch_dir(). And that particular test failed incorrectly in the past before.
Plop that in, rerun the tests and... still broken. No version returned. This is a new behavior. Was it intentional? I dunno. get_perl_arch_dir() has no docs.
The old behavior was wrong, and the old test was written simply so that it matches the behavior of the (incorrect, buggy) code, not to match the (non-existent :-) spec.
Dave? What should the behavior of get_perl_arch_dir when Type is "perl"
with no version?
Then perldir is empty. To quote David from an earlier mail:
"For backwards compatibility, the first kind continued to be stored in /sw/lib/perl5 and /sw/lib/perl5/darwin while the second kind used /sw/lib/perl5/5.x.y and /sw/lib/perl5/5.x.y/darwin."
Cheers,
Max
------------------------------------------------------- This SF. Net email is sponsored by: GoToMyPC GoToMyPC is the fast, easy and secure way to access your computer from any Web browser or wireless device. Click here to Try it Free! https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl _______________________________________________ Fink-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/fink-devel
