On Mon, Nov 24, 2003 at 09:50:01PM -0800, Ben Hines wrote: > I see this was done on purpose... Just the opposite of your change, way > back when.. > > http://cvs.sourceforge.net/viewcvs.py/fink/fink/perlmod/Fink/ > FinkVersion.pm.in?r1=1.5&r2=1.6
The log doesn't say why, just that it happened. Do you have any info about that? > Invesigating this i noticed the Basepath: missing error message does > not work: > > % fink index > Use of uninitialized value in concatenation (.) or string at > /sw/lib/perl5/Fink/Config.pm line 123. > Basepath not set in config file "" Looks like I busted this when I unified new_with_path to use Fink::Base-> new_from_properties. new_from_properties creates the object and calls initialize. Can't wedge _path in there because new_from_properties ignores anything with a leading underscore. :( I'll put the duplicate code back and throw in a test for config file failure. > Also with the old code, it looks like fink would have been able to > print its version and not spew errors when the basepath was not in the > conf file. Now it spews: > > % fink --Version > Package manager version: 0.17.1.cvs > Use of uninitialized value in concatenation (.) or string at > /sw/lib/perl5/Fink/FinkVersion.pm line 85. > Use of uninitialized value in concatenation (.) or string at > /sw/lib/perl5/Fink/FinkVersion.pm line 85. > Distribution version: unknown Since fink knows the basepath just have it set it if its not in your config file. This'll fix lots of other things that'll probably blow up horribly when $basepath isn't set in the config file. However, Fink::Config will die without a basepath. Argh! What we need is some way to supply defaults to new_with_path() which is what I'll code up. -- Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern/ Once is a prank. Twice is a nuisance. But NINE TIMES is a TRADITION. -- Mark-Jason Dominus in <[EMAIL PROTECTED]> ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Fink-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/fink-devel
