On Tue, Jul 20, 2004 at 09:02:49PM +0200, David H. wrote: > Benjamin Reed wrote: > | David H. wrote: > |> jfm wrote: > |> |
> |> | There are probably 2 different issues: one is that in some > |> | cases it may be clearer or more convenient to use several > |> | different 'patchfiles', with very distinct roles _ so a > |> | 'PatchFile' field might have to be plural Yes. Would be PatchFile, PatchFile2, etc. to mirror our SourceN syntax. > |> Actually this is one thing I would veto strongly. There is no valid > |> technical reason for more than one (unified) patch file. Fink has supported multiple patchfiles in the Patch field for a *long* time. Looking at the code, this was intentionally implemented (though no current packages use it. > | Having things split up logically makes it easier to maintain; especially > | when your package consists of multiple source tarballs. Or for variants. Have one .patch that covers basic portability issues, and then other variant-specific and maybe conflicting-with-each-other .patch related to those specific variants. > Once more, there is no _technical_ reason to have more than one patch > file. That it makes things easier to maintain is something I am not > going to argue, however, it makes it harder on our side to > a) verify that every patch file used is present That's what 'fink validate' is for, no? It even knows to look in PatchScript. > b) that each patch file is up to date and the md5 are ok 'fink validate' would obviously check MD5. I'm not sure what yuo mean by "up to date", since one major feature we *gain* by using MD5 is the ability to make sure the patchfile is in sync with .info. > c) that each patch file sticks to the unofficial size limitations we set > a long time ago It would be trivial to add this to the validator. dan -- Daniel Macks [EMAIL PROTECTED] http://www.netspace.org/~dmacks ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click _______________________________________________ Fink-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/fink-devel
