On Sun, Jan 28, 2007 at 01:38:37PM -0600, Christian Schaffner wrote: > Dear Fink developers > > In order to make the 'dump' script of the pdb working with the new > ideas layed out at > > http://wiki.finkproject.org/index.php/Fink:PDB > > and started in the 'redesign_pdb' branch, I would like to commit the > attached path to fink. It introduces two new methods (get_desc_detail > and get_desc_usage) to get description and usage details with percent > expansion, but otherwise unformatted.
A generic function for getting a field with canonical prefix is a good idea! The .info fields are named "descdetail" and "descusage", not "desc_detail" and "desc_usage". Best to keep accessors named as closely to the data they access as possible to avoid programmer confusion. OTOH, do we really need to have specific accessors for them? In almost every place we use that data, we don't use the canonical prefix, so it becomes the same as param_expanded. In a rare place we would need the canonical prefix, but we probably need it for several different fields in that same place. Maybe it would be better just to have the (presently) private more generic method made public. That way the caller could loop over several fields by name instead of having to call each field-specific accessor. Programming nit: I don't think you need to check for defined()ness of $_[0] before staashing @_ in @options. Or at least we don't do that anywehere else IIRC. dan -- Daniel Macks [EMAIL PROTECTED] http://www.netspace.org/~dmacks ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Fink-devel mailing list Fink-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/fink-devel
