Daniel Macks wrote: > On Thu, Jan 03, 2008 at 03:22:48PM -0800, Jesse Alama wrote: > [snip good rationale for...] >> The relevant code change is in line 450 of build.c in the >> subdirectory dpkg-deb of version 1.10.21 of dpkg: >> >> execlp(TAR,"tar","-cf", "-", "--null", "-T", "-", "--no-recursion", >> "--no-unquote", (char*)0); >> >> instead of >> >> execlp(TAR,"tar","-cf", "-", "--null", "-T", "-", "--no-recursion", >> (char*)0); >> >> What would be the consequences of adding this flag to the invocation of >> tar? Do we know of any packages that require that the --no-unquote flag >> be absent? > > Is dpkg assured of running fink's tar here? That flag is only > supported by /sw/bin/tar, not apple's /usr/bin/tar (at least not on > 10.4).
Nor on 10.5; /usr/bin/tar is still at version 1.15.1. But Fink's tar is in the dependency list of dpkg, so it should be used. As you will remember, we saw this a year ago when Fink's tar was upgraded to 1.16.1 and dpkg started spitting warnings about nul characters. We then patched exactly the line in question (although in a backward compatible way). Such a change would have to be thoroughly tested, of course (how are file names with spaces handled, for example?), but I think it would make sense. Currently, dpkg produces a list of file names using "find . ... -print0", which are not quoted but "raw" file names, and feeds this list to tar which unquotes them. This is not very logical. -- Martin ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Fink-devel mailing list [email protected] http://news.gmane.org/gmane.os.apple.fink.devel
