On Apr 30, 2008, at 12:44 PM, Tomoaki Okayama wrote: > Thanks for lots of comments! > I attach a new patch for gimp2.info. > > >> One question: in InstallScript: >> >> - (cd ../gimp-help-2-0.5; make install DESTDIR=%d) || exit 1 >> + (cd ../gimp-help-2.4.1; make install DESTDIR=%d >> top_builddir=`pwd`) || exit 1 >> >> I've never seen an explicit top_builddir needed before. Any idea what >> is happening here? >> > If top_builddir is not specified, the following error occurs in my > env: > > (cd ../gimp-help-2.4.1; make install DESTDIR=/sw/src/fink.build/root- > gimp2-2.4.5-1) || exit 1 > Making install in quickreference > make[2]: Nothing to be done for `install-exec-am'. > make[2]: Nothing to be done for `install-data-am'. > make[2]: Nothing to be done for `install-exec-am'. > ././install-sh -c -d /sw/src/fink.build/gimp2-2.4.5-1/sw/share/gimp/ > 2.0/help > ** Installing HTML:/bin/sh: ././install-sh: No such file or directory > > Any other ideas for avoiding it?
Sounds like a bug in their build system. Patching automake files can be painful, so if that's the smallest fix it seems fine to me. > At Wed, 30 Apr 2008 10:51:11 -0400, > Benjamin Reed wrote: >> >> Daniel Macks wrote: >> >> |> - Add --disable-python. >> >> | Looks functionally nearly the same as the one I have locally for >> it. >> | Two issues: >> >> Also, why disable python? >> > If enable python, some messy changes should be done, and lots of > dependency should be added, which may be painful for the maintainer > and users. > My patch changes gimp2.info as little as possible from the original > one. > > At Wed, 30 Apr 2008 10:59:11 -0400, > Alexander Strange wrote: >> >> There's another new package for it here: >> http://sourceforge.net/tracker/index.php?func=detail&aid=1942780&group_id=17203&atid=414256 >> >> For some reason I can't find the start of this thread in gmane or my >> inbox, so I can't compare them. >> > As noted above, my patch follows your original packaging way. > Another one seems to make some big changes in packaging. > It's difficult for me to say which is better. > Which one do you like? Hmm... Well, the differences I see are: - This one is a diff from the package I know works. I like that a lot better, since I haven't tried the rewritten one yet. - The other one patches it to use 'open' for help reading. I'm not sure what it does without that, but it might not work without a 'firefox' command. - The other one gets rid of the variants. I'd like to keep -svg, but - noprint can go. It's already broken and apparently not necessary anymore. - I'd prefer gimp-help in the same package since it's only useful for this version. And this one strips debug symbols on everything (since it's large), while the rewritten package gets rid of that. I don't think we have a policy about this, but since the package is pretty big I don't see any harm in it. So, I guess I'd rather use this one, since we can follow the differences more easily. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Fink-devel mailing list Fink-devel@lists.sourceforge.net http://news.gmane.org/gmane.os.apple.fink.devel
