-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/21/11 9:37 AM, Prerna Atri wrote:
> 
> Hi,
> 
> We have submitted TeXworks package for review.
> 
> Kindly review and suggest any required modifications.
> 
> *The "**dpkg -L texworks" output is given below:*
> /.
> /sw
> /sw/Applications
> /sw/Applications/TeXworks.app
> /sw/Applications/TeXworks.app/Contents
> /sw/Applications/TeXworks.app/Contents/Info.plist
> /sw/Applications/TeXworks.app/Contents/MacOS
> /sw/Applications/TeXworks.app/Contents/MacOS/TeXworks
> /sw/Applications/TeXworks.app/Contents/PkgInfo
> /sw/Applications/TeXworks.app/Contents/Resources
> /sw/Applications/TeXworks.app/Contents/Resources/TeXworks.icns
> /sw/bin
> /sw/lib
> /sw/lib/texworks
> /sw/share
> /sw/share/doc
> /sw/share/doc/texworks
> /sw/share/doc/texworks/COPYING
> /sw/share/doc/texworks/README
> /sw/share/man
> /sw/share/man/man1
> /sw/share/man/man1/texworks.1
> 
> 
> *The contents of the .info file are as below:*
> 
> Package: texworks
> Version: 0.3
> Revision: 1
> Source: http://sourceforge.net/projects/texworksmac/files/%n-%v.zip
> Homepage:  http://www.tug.org/texworks/
> Maintainer: Prerna Atri <prerna.a...@iiitb.org
> <mailto:prerna.a...@iiitb.org>>
> License: GPL
> Description: GUI for typesetting TeX documents
> Source-MD5: d209a7fe185c08ded7c40503bf7d16c2
> Depends: system-java (>=1.6-0), pkgconfig, fontconfig-config,
> poppler-data, hunspell
> BuildDepends: qt4-mac, poppler4-qt4-mac
> CompileScript: <<
> #!  /bin/sh  -ev
> qmake
> xcodebuild ARCHS=x86_64
> <<
> InstallScript:  <<
> #! /bin/sh -ev
> mkdir  %i/bin
> mkdir  -p  %i/lib/%n
> mkdir  -p %i/share/doc/%n
> mkdir  -p %i/Applications
> mkdir  -p %i/share/man/man1
> cp -Rf %b/TeXworks.app %i/Applications/.
> cp %b/README %i/share/doc/%n/.
> cp %b/COPYING %i/share/doc/%n/.
> cp -Rf %b/man/* %i/share/man/man1/.
> <<
> #DocFiles:
> DescDetail:  <<
> Open source application software for typesetting technical documents.
> <<
> DescPackaging: <<
> To avoid possible failure due to circular dependeny between glib2,
> shared-mime-info and gtk:
> 1. Build glib2 library without -m before texwoks build.
> OR
> 2. Install Fink package destop-file-utils before texworks build.
> <<
>  
> 
> Thanks and Regards,
> Prerna Atri.
> 
> 
> 

Follow the standard naming conventions for our qt packages.  Name this
texworks-mac, to allow for the possibility of a qt4-x11 version.

Don't bother with that DescPackaging note.  That's not a problem which
_this_ package specifically needs to address.

Why are you creating %i/bin %i/lib/texworks when you don't install
anything in those directories?

Instead of copying the app bundle manually, why not use an AppBundles field?

Similarly, copying the README and COPYING files manually isn't
necessary.  That's what the DocFiles Field is for.

You probably need a BuildDepends: system-java-dev (>=1.6-0), since you
Depend on system-java (>=1.6-0)

Your Depends are totally inadequate.  Why do you have a Depend on
pkgconfig, which is normally needed only at build time?  If you
BuildDepend on qt4-mac, you have to Depend on the corresponding shared
library packages.  Similarly for poppler4-qt-mac.

And use the submissions tracker instead of emailing this stuff around.
- -- 
Alexander Hansen, Ph.D.
Fink User Liaison
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1ifb4ACgkQB8UpO3rKjQ/C+wCgh0q0t/U7KtdNqGD0fZCtMldQ
hKgAnA3juSZ1n2GLUhFhS0YlUokH6UJB
=ddWl
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Fink-devel mailing list
Fink-devel@lists.sourceforge.net
http://news.gmane.org/gmane.os.apple.fink.devel
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-devel

Reply via email to