On Sun, 19 Jan 2014 10:39:56 -0500, Charles Lepple <clep...@gmail.com> wrote:
On Jan 16, 2014, at 11:20 PM, Charles Lepple wrote:
>
> The cgi-formbuilder-pm.info file passes validation, but if any Perl 
> experts want to glance at it (I'm used to packaging Python and C 
> stuff), it's in a temporary branch here before I commit everything to 
> CVS:
>
> https://github.com/clepple/fink-dists/commit/18712affa0b2784f8ef033cd5222d72406d42963

Looks like a good package. Some technical improvements... 

License could be expanded to be Artistic/GPL (per statement in README 
and INSTALL). 

Instead of creating %i/lib/perl5/%type_raw[perl]/man/ and then moving 
just the man/man3/ subdir into it, you can just move the whole man/ 
(%i/lib/perl5/%type_raw[perl]/ already exists, so that saves a step and 
also avoids leaving a stray empty man/ dir). 

Makefile.PL has some checks for optional modules that fink does supply 
via other packages. You could Recommends: them. But the test suite also 
uses them, so they would also be good InfoTest:TestDepends: entries. If 
they themselves don't have large dep trees and/or the features they are 
common and useful, I tend to just Depends: them so that other users 
don't have to figure out fink's package-naming to find them. 

dan

  --
Daniel Macks
dma...@netspace.org



------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Fink-devel mailing list
Fink-devel@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.devel
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-devel

Reply via email to