2012/11/2 Hanspeter Niederstrasser <[email protected]>
> On 10/31/2012 11:54 AM, pantxo diribarne wrote:
>
>> Hello,
>>
>> I am new to fink packaging (so sorry in advance for dummy errors) and
>> would
>> like to add libmodbus to the list of fink packages. I have prepared a
>> libmodbus.info script (see attachment) in which I had to choose apple
>> llvm-gcc-4.2 (CC variable in ConfigureParams) in order to compile. Is it
>> acceptable or should I try to understand why fink default compiler don't
>> work?
>>
>
> Thanks for the submission. For future reference, submissions are better
> handled through the Submissions Tracker: http://sourceforge.net/**
> tracker/?group_id=17203&atid=**414256<http://sourceforge.net/tracker/?group_id=17203&atid=414256>
>
> Your submission seems OK for the most part. Looking at the failure that
> occurs when NOT using llvm-gcc-4.2, it seems to have been fixed in the Git
> source: https://github.com/stephane/**libmodbus/commit/**
> 4396649fe040334c61543856624fb8**f75bec4b86<https://github.com/stephane/libmodbus/commit/4396649fe040334c61543856624fb8f75bec4b86>
>
> If that is indeed the needed fix, then please adapt that into a PatchFile.
> Using clang whenever possible is the preferred solutions since llvm-gcc
> might go away in the future.
>
> According to the github page <https://github.com/stephane/**
> libmodbus/downloads <https://github.com/stephane/libmodbus/downloads>>,
> the latest release is 3.1.0, but that release doesn't show up the home
> page. If 3.1.0 is a valid release, can your submission be bumped to that
> version?
>
> Finally, the GCC: 4.0 field is only needed if your package uses C++ code
> (yes, the naming is confusing), which doesn't seem to be the case here.
>
> Please make a new tracker item at the above Sourceforge link so that we
> can continue discussion there. Thanks again for your submission.
>
> Hanspeter
>
> Thank you Hanspeter,
I'll look wether the patch you pointed me to solves the compile error, and
make the necessary fink PatchFile if needed. I'll also remove the GCC=4.0
statement in the info file.
About the 3.1 version, the official web page doesn't mension it and it was
uploaded on github before the current official stable release 3.0.3. It is
probably meant to be a developper version, preparing for 3.2.x
Should I realy prefer the 3.1?
Pantxo
------------------------------------------------------------------------------
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
_______________________________________________
Fink-users mailing list
[email protected]
List archive:
http://news.gmane.org/gmane.os.macosx.fink.user
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-users
