On Tue, Jan 28, 2014 at 1:30 PM, Jens Axboe <[email protected]> wrote: > On Tue, Jan 28 2014, Grant Grundler wrote: >> csscope showed rand_seed was defined 4 times - each a different type. >> While they are used differently, the places where they overlap >> should reference the same type. This patch makes three of them the same >> as suggested by Jens Axboe. > > Time for public shaming, as you did not even compile this patch!
No, I didn't. :) I told you I didn't test it. > I'll let you figure out the issue :-) Oh man...harsh master :P - o->rand_seed = le32_to_cpu(top->rand_seed); + o->rand_seed = le64_to_cpu(top->rand_seed); I saw this when reviewing the code but didn't realize "top" was the packed version that got changed. Resending V2 Compiled and lightly tested on x86, not ARM where I'm doing most of my testing these days. :) cheers, grant -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
