Hi there, I had a question about adding a test. Is that as straightforward as adding to the example code in the docstrings for the pysparseMatrix.multiply() method? How can I then run the test for that specific class/class method?
Charles On Thu, Mar 20, 2014 at 8:15 AM, Daniel Wheeler <[email protected]>wrote: > On Wed, Mar 19, 2014 at 4:23 PM, Charles Reid <[email protected]> > wrote: > > Hi there, > > > > I found a bug in Fipy's Pysparse class that raises an error when sweeping > > toward a solution with a vector PDE. Some notes on the problem are here: > > > > > http://charlesmartinreid.com/wiki/Category:Fipy#Pysparse_TypeError_Using_Vector_Equations > > > > In short, the problem results from trying to treat a square matrix > (number > > of variables x number of gridpoints) as a vector. This can be easily > > resolved by adding a "ravel()" call, which turns the matrix into a > vector. I > > have a patch file here: > > > > http://files.charlesmartinreid.com/pysparseMatrix.patch > > Hi Charles, > > Thanks for the patch. Do you have a small test case that I can add to > the test suite to show the problem? > > Also, would you like to patch FiPy yourself and add in the test case? > That way you will get recognition and have your name on the list of > contributors. You could just push your changes to a public repository > (Github for example) and then I can pull from there. > > Thanks. > > BTW We will be switching to Github soon, which will make this process > much easier. > > -- > Daniel Wheeler > _______________________________________________ > fipy mailing list > [email protected] > http://www.ctcms.nist.gov/fipy > [ NIST internal ONLY: https://email.nist.gov/mailman/listinfo/fipy ] >
_______________________________________________ fipy mailing list [email protected] http://www.ctcms.nist.gov/fipy [ NIST internal ONLY: https://email.nist.gov/mailman/listinfo/fipy ]
