On 11-04-2011 20:23, Claudio Valderrama C. wrote:
>> -----Original Message-----
>> From: Adriano dos Santos Fernandes [mailto:adrian...@gmail.com] 
>> Sent: Lunes, 11 de Abril de 2011 18:10
>>
>> Usage of namespaces in our code is very ugly, as we divide things in
>> main-level namespaces.
>>
>> In headers, we have lot of "Firebird::". They're specially 
>> ugly in this
>> type of usage:
>> Firebird::Pair<Firebird::Full<Firebird::string, 
>> Firebird::MetaName> > >
>>
>> With make almost "obligatory" to create extra typedefs.
> 
> Yes, we have lots of typedef to shorten this thing.
> 
>  
>> I suggest we fix namespace usages in an incremental manner. How?
>>
>> We put in firebird.h this:
>> -------------------
>> namespace Jrd
>> {
>> }
>>
>> namespace Firebird
>> {
>>     namespace Engine
>>     {
>>         using namespace Jrd;
>>     }
>> }
>> -------------------
> 
> I assume you suggest to replace namespace Jrd by Engine and put it inside
> Firebird, right?
> 
Yes, the rename is not the main point, but just to move incrementally
without confusion.

I've missed compatibility between Jrd and Firebird::Engine. In
firebird.h we would need:
-------------------
namespace Firebird
{
    namespace Engine
    {
    }
}

namespace Jrd
{
    using namespace Firebird::Engine;
}

namespace Firebird
{
    namespace Engine
    {
        using namespace Jrd;
    }
}
-------------------


Adriano

------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now!  http://p.sf.net/sfu/ibm-webcastpromo
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to