Claudio,

> People, I think that true and yes are enough, the "y" value is superfluous:
> 
> bool Config::asBoolean(const ConfigFile::String &value) {
>       return (atoi(value.data()) != 0) ||
>               value.equalsNoCase("true") ||
>               value.equalsNoCase("yes") ||
>               value.equalsNoCase("y");
> }

Am I reading this correctly; any non-zero value would be considered true?

If so, then I do not agree with this logic.  "True" values must be specific, 
all other values must be false.


> Soon, we will have to add "t" as an abbrev for "true" and so on. I think that 
> many ways to specify the same thing leads to confusion.

I agree, we should be using the established XML Schema Part 2 Boolean Datatype 
specification (http://www.w3.org/TR/xmlschema-2/) -- "true"/"false" and 1/0 
only.

Perhaps all non-conforming values could be logged in the firebird.log file 
("non-conforming value 'x' found for configuration value 'y', value 'false' 
assigned")


Sean

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to