> So the solution is either to check return value for NULL in > xnet_connect_wait_thread() (as inet_connect_wait_thread() does) or throw > exception instead of returning NULL, either in XNET_connect() or as deep > as in connect_server() (in src/remote/os/win32/xnet.cpp). I'm not > familiar with the code enough to decide which option is preferrable. > > BtW, the same problem is likely with wnet_connect_wait_thread() which > doesn't check return value of WNET_connect() either (but I didn't check > whether it can actually return NULL).
Yes, the bug is in xnet_connect_wait_thread() and in wnet_connect_wait_thread(). But in v2.5 there was correct code, so bug was introduced in trunk only. So far i'm failed to see revision before 51654, i.e. before srvr_w32.cpp was moved from src/remote/os/win32 to the src/remote/server/os/win32... Regards, Vlad ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel