src/gpre/gpre.cpp:1815: possible bad if test ?
----------------------------------------------

                 Key: CORE-4257
                 URL: http://tracker.firebirdsql.org/browse/CORE-4257
             Project: Firebird Core
          Issue Type: Bug
          Components: GPRE
    Affects Versions: 2.5.2 Update 1
            Reporter: David Binderman


I just compiled the source code of firebirdsql-2.5.2 with extra Linux gcc 
compiler
flag -Wlogical-op.

It said

../src/gpre/gpre.cpp:1815:22: warning: logical 'or' of collectively exhaustive 
tests is always true [-Wlogical-op]
../src/jrd/ods.cpp:44:35: warning: logical 'and' of mutually exclusive tests is 
always false [-Wlogical-op]

I've checked them both and they both look like && / || mixups. 
Suggest code rework.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to