On 01/17/14 19:33, Dmitry Yemanov wrote: > 17.01.2014 19:16, Adriano dos Santos Fernandes wrote: >> I think IUtl::version > Being there, please rename it to getVersion(). As usual, I'm strongly > against nouns used as routine names.
Done. > >> Also I think IUtl::edit should not exist. It's a too specialized ISQL >> feature, and IMO should be there in ISQL. > I agree. Done. >> I think IUtl::version should not call a IVersionCallback. IMO it should >> receive a buffer and length and write to it or return how many bytes are >> required for the buffer. Not very handy, but surely less cumbersome than >> a callback. Here I disagree. getVersion() does not return single string - it returns a set of strings, and if we collapse it in single line (separating somehow) user's routine has to parse them. Must say that I've tried to do such change and in ISQL result was ugly. ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
