On 03/05/2014 05:46 AM, Adriano dos Santos Fernandes wrote: > Hi! > > Only at Plugin.h, we have two case conventions for constants. > > PluginType constants uses a convention I don't remember to see before, > example: FirstNonLibPlugin.
That definitely requires cleanup. > DirType uses ALL_CAPS style. > > Also one starts in 1 and another starts in 0. > > And if we go to Provider.h IStatement, specific constants are declared > inside the container class, not as a namespace. I surely prefer this > when possible, leaving namespace for generic constants. > > OK, I see no problems using this way. ------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
