At some point of changes 4 parameters (blr, blr length, buffer, buffer length)
were gathered in single structure. Later after adding message metadata 2 values
left in that structure - metadata pointer and buffer pointer. Later structure
was removed - 2 pointers are transfered now independently. I certainly agree -
internal message buffer makes no sense now. Ideally it should be gone when
removing mentioned structure.
-----Original Message-----
From: Dimitry Sibiryakov <[email protected]>
To: For discussion among Firebird Developers
<[email protected]>
Sent: сб, 08 марта 2014 17:46
Subject: Re: [Firebird-devel] InternalStatement::doExecute()
08.03.2014 14:18, Vlad Khorsun wrote:
> If you really interested, you can look at few previous revisions of this
> code.
From code changes and commit comments it looks like Alex just did some mass
search-and-replace cleanup without real cleaning of pointless code.
> With current state of things InternalMessageBuffer is useless in
> InternalDS.cpp
That's why I ask what it does there. It is the only place which use "almost"
copy
constructor. If this place can be cleaned out, InternalMessageBuffer can be
cleaned as well.
--
WBR, SD.
------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
Firebird-Devel mailing list, web interface at
https://lists.sourceforge.net/lists/listinfo/firebird-devel
------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
Firebird-Devel mailing list, web interface at
https://lists.sourceforge.net/lists/listinfo/firebird-devel
