I just saw this commit
https://github.com/asfernandes/firebird/commit/23072a0d77e8a6c2b4972800d31285e96fa28dd8

This commit replaces (apparently) incorrect  uses of a constant with a
magic value. Can I suggest that this is either reverted, or replaced with a
new, correctly-named constant? Magic values make code harder to understand
(even when there is a comment).

Mark

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to