On 07/01/14 16:36, Dimitry Sibiryakov wrote: > 01.07.2014 14:24, Alex Peshkoff wrote: >> 1. It must be single instance per module, therefore may be used as an >> unique marker for it. > I saw nowhere this requirement is written. > Plugin factory, BTW has the same quality, so I really don't see a reason > for a separate > class.
You are wrong - module may (and does - Win_Sspi) contain >1 factories. > Every plugin module already has unique marker, it is handle returned by > LoadLibrary()/dload(). What is a second one for?.. A bit easier to access inside plugin module. > >> 2. doClean() makes it possible to set module cleanup routine if needed > Separate exported function can do the same but don't require to implement > unnecessary > methods (including ridiculous in this case getModule()). Yes, it may be replaced. But it combines very nice with unexpected unload detection. >> Currently we do not need any more module-level functionality, if/when >> need we will add methods to interface. > What if a plugin does not require any special cleanup? Can it return NULL > from > getModule()? Is engine ready to get this NULL from it? > Not. ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
