People, I failed to see this commit before in jrd\functions.cpp in FB 2.5,
inside set_context().

Before the change:
        thread_db* tdbb = JRD_get_thread_data();
        if (!tdbb)

After the change:
        thread_db* tdbb = JRD_get_thread_data();
        Database* dbb = tdbb->getDatabase();

        // See if JRD thread data structure looks sane for occasion
        if (!tdbb || !dbb)

You'll agree that the check for !tdbb became obsolete or the code should be
reordered because tdbb is used to get dbb before it's tested for NULL.

;-)

C.
---
Claudio Valderrama C.
Consultant, SW developer.


------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to