ISQL: add warning / error message when script contains several 'IN' commands 
without delimiter (semicolon) between them
-----------------------------------------------------------------------------------------------------------------------

                 Key: CORE-4948
                 URL: http://tracker.firebirdsql.org/browse/CORE-4948
             Project: Firebird Core
          Issue Type: Improvement
          Components: ISQL
            Reporter: Pavel Zotov
            Priority: Minor


1) create new database
2) create three .sql files:
`f1.sql` - with single command like:  recreate table test1(id int);
`f2.sql` - with similar command but for another table:  recreate table test2(id 
int);
`f3.sql` - similar to `f2.sql` but for table 'test3'.

3) create "main" script, let its name will be 'fm.sql', with content:
===
set echo on;
in f1.sql 
in f2.sql 
in f3.sql
commit;
show table;
===

or with such:
===
set echo on;
in f1.sql in f2.sql in f3.sql
commit;
show table;
===

NOTE: there is NO delimiter (semicolon) between "IN" statements.

Than run isql and look at result:

C:\FBTESTING\qa\fbt-repo\tmp>isql /3333:e30 -i fm.sql 1>log 2>err

C:\FBTESTING\qa\fbt-repo\tmp>type log
in f1.sql in f2.sql in f3.sql
commit;
recreate table test1(id int);
show table;
       TEST1

C:\FBTESTING\qa\fbt-repo\tmp>dir err | findstr /i /c:"err"
30.09.2015  01:13                 0 err

No alerts and only one table has been created. 
I'm not sure that this is a bug because "IN" command does not belong to DML/DDL 
set. 
But ISQL should produce at least warning about scripts that were SKIPPED from 
execution.

(when script is typing by programmer this delimiter missing can be easy noted; 
but this will be difficult task when some complicated script is generated by 
*another* command scenario  (.bat  / .sh) which contains such 'small' error 
like mentioned above).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to