On 15/03/2016 09:41, Dimitry Sibiryakov wrote: > 15.03.2016 13:24, Adriano dos Santos Fernandes wrote: >> You should at least test every code path related to the functions you >> changed the input/output code page, like code paths related to files >> names in databases (external files, shadows, whatever). > I was explicitly asked by admins not to make wide patches. Every single > issue will be > fixed separately.
No regressions in any commit is top priority. >> Also should test old client (which cannot use utf8_filename dpb) >> connecting to new (with your change, and already one without it) >> checking it work as originally. > Originally it doesn't work at all. That's what all these tickets are > about. Connection > strings without isc_dbp_utf8_filename inside are handled by server y-valve as > before, no > changes in this regard. > It surely work. Without isc_dbp_utf8_filename ever work as intended. You sure should test this with different servers and clients. Support for isc_dbp_utf8_filename was implemented given the limitations of being using the ANSI API with FS functions, so working. Adriano ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
