On Wed, Mar 23, 2016 at 10:59:20AM -0400, Jim Starkey wrote:
> 
> Defining your own macro layer gives you cheap portability and a zero 
> overhead implementation.

That's one side of it. The other is that for occasional contributors or
distribution support guys, it brings a lot of confusion. Like when you
find out that ULONG is in fact not unsigned long as one would expect
from the name but rather what standard calls uint32_t). Or when you
learn that instead of a standard library function you are supposed to
use this compatibility wrapper. Regular contributors have learned these
and got used to it; for newcomers, it can be tough at times.

The portability you mention is nice but it's paid for by readability and
maintainability of the code. Most of the stuff is historical and it
would be unwise to rush into weeding it out. But we should think twice
before adding more.

                                                          Michal Kubecek

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to